All the talk about golden eyes was totally unnecessary, really. They basically tried to make something up without having the need to do so at all.
You go to Silithus and you'll find dozens of elves with golden eyes manning their posts as ordinary guards. Same applies for many other, randomly generated night elf NPCs. Shows you how they've only recently come up with this "golden eyes = uber destiny" thing and never thought about it before.
Doesn't have all Night Elf Males Golden Eyes now?
And weren't Malfurion and Illidan supposed to be fraternal twins? After all, not even their face structure looks similar and they also have different hair colors.
This is the first time I've noticed that he has silver eyes in game. His Cataclysm model apparently did, too. Why on earth? His vanilla model, the one used for that brief encounter that players on the Shifting Sands (I think that was it) quest chain got to see -- that one had golden eyes.
This actually bothers me a lot. Come on, it's Malfurion here. He earned his golden eyes. Gief him them nao, pls Blizz thx.
- - - Updated - - -
Actually it's really old lore that goes back as far as when the night elves were introduced. It's more likely that they forgot about it over the years, to be honest.