Classic - Ashenvale
TBC - Nagrand
Wotlk - Very hard because i liked so many of them but i think Grizzly hills or Storm Peaks
Cata - Vashj'ir , it's just a superb zone
MoP - I pretty much hated all the zones except Krasarang Wilds , so i guess i'll go with that
WoD - Gorgrond
Zone design has changed much throughout the years, and it has changed for the worst. Gone are the zones that have a area or a road there just so it looks cool or to make the zone be / feel larger, zones now are a nothing but a point A to point B path where you go and kill the quest mob,a poor choice.