While I agree with your points about where the SWTOR free to play went wrong, I would like to point out that your free sample analogy does not really work. What you are describing, in video game terms is a demo. F2p is not a demo and should not be treated as such.
Other then that, I totally agree. The constant beating over your head with "subscribe to unlock this core gameplay mechanic" stuff at every turn is very frustrating. I have a feeling that while they will certainly see a boost in revenue for the first month or three, it will have a very large drop off. It is great that they are listening to feedback and trying to make adjustments to the restrictions, most players will not stick around long enough for that to have an impact on them. It is too bad really because the game is pretty good, not great or anything, but pretty good. I kind of feel like Bioware should have just made KOTOR 3 with 8 fully fleshed out single player storylines and sold it without all the MMO crap tacked on.