The crit bonus is calculated when Starfire lands not when you start casting it. So if you try to time the last cast so it lands outside the eclipse, As I got the impression poldara was doing. Then YOU WONT BENEFIT FROM THE CRIT BUFF FROM ECLIPSE.
Seems to me like poldare is eather 1. dont play a moonkin 2. plays a moonkin but got no clue about what and where 3. is a troll.