DKs, no doubt. You can more or less ignore them while healing since they can keep themselves up for ages. Yeah, it's nice with other tanks with amazing avoidance, cool, I don't have to heal hits that miss the druid, I STILL have to heal the ones that do. With DKs, I don't. They heal themselves.
Felt I had to quote and bold that because I'm sick of seeing tanks in huge amounts of stam gear with little to no avoidance/mastery etc.
Purely from the perspective of a healer, I find warriors to be the best tanks. The damage is usually nicely smoothed out and not very spikey which makes my life oh so much easier, they also appear to be quite technical tanks to play, which typically sees baddys drop them for other classes leaving the better players behind (this is just my take on it).
Paladins are my second favorite as even the worst ones tend to know how to drop consecration and I don't end up pulling mobs with heal threat and they also tend to know about their self heal abilities (hello lay on hands!) as I assume they figured those out while leveling.
Third are bears, because they are crap for aoe tanking and they just feel like they need more healing overall.
And in last place, even though it feels so cliched to say it are DKs, because they're typically played by baddys. I honestly believe skipping out 55 levels of leveling makes many people worse players and coupled with the fact that a lot of DKs are rolled literally because you can skip so many levels (which says a lot about the player in general), all adds up to a generally poor experience.
Again, these are just my observations and not qualified with any experience of actually playing a tank (although I've started to level a warrior based on these observations as a bit of a hobby).