Nedd help with a program (c++)

[Rakeer]

So I've been trying to complete this stupid programing problem for the past week or so but I can't figure it out.
the problem is a (seemingly) simple one.

-take an inputed number
-convert it to octal (base eight)
-arrange the digits in the octal number in ascending order
-subtract the re-arranged number, from the octal. in base eight.
-do this 5 times, or until the digits in the octal are in ascending order
-convert back to base 10

heres my code:

#include <stdAfx.h> 
#include <iostream> 
using namespace std; 
 
int base_eight(int number); 
int sort(int number); 
int base_ten(int number); 
 
void main(){ 
    int number; 
    int sorted; 
    int counter; 
    int temp; 
 
    for(int ia = 0; ia < 5; ia++){ 
        number = 0; 
        sorted = 0; 
        counter = 0; 
        temp = 0; 
        system("cls"); 
        cout << "Enter a number: "; 
        cin >> number; 
        temp = number; 
        number = base_eight(number); 
 
        while(1){ 
            sorted = sort(number); 
            sorted = base_ten(sorted); 
            number = base_ten(number); 
            if(number == sorted) 
                break; 
            number = number - sorted; 
            number = base_eight(number); 
            counter++; 
            if(counter == 5) 
                break; 
        } 
        number = base_ten(number); 
 
 
        cout << number << endl; 
        system("PAUSE"); 
    } 
} 
int base_eight(int number){ 
    int place[100]; 
    int first = 0; 
    int counter = 0; 
    int octal = 0; 
    int power; 
    while(1){ 
        place[counter] = number % 8; 
        counter++; 
        first = number / 8; 
         
        if(first < 8) 
            break; 
 
        number = first; 
    } 
 
    place[counter] = first; 
 
    for(int ia = 0; ia <= counter; ia++){ 
        power = 1; 
        for(int ib = 0; ib < counter - ia; ib++){ 
            power = power * 10; 
        } 
        octal = octal + (place[counter - ia] * power); 
    } 
    return octal; 
} 
int sort(int number){ 
    //will turn 4154 into 1445 
    int counter = 0; 
    int digit[101]; 
    int place[101]; 
    int final; 
     
    //break the number 
    while(1){ 
        digit[counter] = number % 10; 
        if(number == digit[counter]) 
            break; 
        number = number - digit[counter]; 
        counter++; 
        number = number / 10; 
    } 
 
    //number the places 
    for(int ia = 0; ia <= counter; ia++){ 
        place[ia] = 0; 
        for(int ib = 0; ib <= counter; ib++){ 
            if(ib != ia){ 
                if(digit[ia] < digit[ib]){ 
                    place[ia]++; 
                } 
            } 
        } 
        for(int ic = 0; ic <= counter; ic++){ 
            if(ic != ia){ 
                if(place[ia] == place[ic]) 
                    place[ia]++; 
            } 
        } 
    } 
 
    for(int ic = 0; ic <= counter; ic++){ 
        for(int id = 0; id < place[ic]; id++){ 
            digit[ic] = digit[ic] * 10; 
        } 
        final = final + digit[ic]; 
    } 
 
    return final; 
} 
int base_ten(int number){ 
    int digit[101]; 
    int counter = 0; 
    int final = 0; 
 
    while(1){ 
        digit[counter] = number % 10; 
        if(number == digit[counter]) 
            break; 
        number = number - digit[counter]; 
        counter++; 
        number = number / 10; 
    } 
 
    for(int ia = 0; ia <= counter; ia++){ 
        for(int ib = 0; ib <= counter - ia - 1; ib++){ 
            digit[counter - ia] = digit[counter - ia] * 8; 
        } 
        final = final + digit[counter - ia]; 
    } 
     
    return final; 
}  

I've checked the seperate functions by themselves and they work just fine. its just when i put them together i seem to get junk numbers from no where, or at least I can't find them. If any other programers can assist in pointing out my errors it will be greatly appreciated.

[Yohassakura]

Your first for & while loop combo is a bit crazy...

To me,

while(1){

doesn't particularly make sense to me, while what is 1? D:

SORT:

 for (int j=0; j < index-1; j++) { //checks the value at index 0 + index 1
            //^if it's not larger, move to the next index values (and repeat).
            for (int k=0; k < index-1; k++) { //k is 0, but while it's less than 1 keep adding 1 to k
                //if k is greater than the number in the next array's index value, then move k up one slot
                if (intArray[k] > intArray[k+1]) {      
                    temp = intArrayTwo[k]; //temp = whatever value is in the array at (variable called 'k')
                    intArrayTwo[k] = intArrayTwo[k+1]; //the value of k is now +1 of k
                    intArrayTwo[k+1] = temp; //k+1 is now equal to the temporary figure
                                       
                    System.out.println("Swap " + swapValue); //print how many swaps have happened
                    swapValue = swapValue+1; //Add 1 to swapvalue for each time it loops around
                    
                    UserInput.readString(); //Slow process down by requiring the user to hit 'Enter' key.                    
                }
            }
        }

int base_eight(int number){
    ...
        place[counter] = number % 8;
        counter++;
        first = number / 8;

This part doesn't look quite right.

Personally, i'd set it up like this:

Enter your whole number (let's say 65), then divide the number by 8 (8) then % 65 so you get 1.
Save these numbers individually
Index position 0 = 8
Index position 1 = 1

Copy array numbers

Sort the new array

old array - new array (Index 0 - Index 0, Index 1 - Index 1)

convert to base 10

output answer
...
Looking back over it;

-subtract the re-arranged number, from the octal. in base eight.
-do this 5 times, or until the digits in the octal are in ascending order

This doesn't really make much sense. - I can't see why would you want to subtract the re-arranged number 5 times, OR (until you) have the numbers in ascending order..?

[Rakeer]

while what is 1? D:

while(1){} is just a form of infinite loop. essentially it means while 1 is true, or 1 is equal to one. the "break;" command exits the loop.

maybe im misunderstanding the ideas your conveying. but the user only inputs a number once per cycle. And you have go through the process 5 times or until numbers are in acsending order cause thats what the damn problem is asking for.

thanks for the help though, I'll try another crack at this once im not so brain dead from trying.

[Sunshine]

I don't have somewhere to run code easily at hand right now, but have you tried putting in a bunch of cout statements to try to debug it? Print the input number, print the octal conversion, print the rearranged number, print the result of the subtraction, print when you're exiting the loop. It might help to find what's wrong.

You can paste it here also; maybe it'll help us see what's going wrong.

[Dassen]

I would check it out thoroughly but it's 5:55am where I live so my mind is working on sub-par performance, I'll check back when I wake up.
Also, you should check out do while, it's a kind of 'better' version of the while loop (not necessarily better, as for everything in programming it depends on the situation and context).
(I have no idea if I'm using the code formatting for these forums here)

int a = 0;
do
{
cout << a;
} while (a != 0);

Console would print:
0
---------------------------------
int a = 0;
while (a != 0)
{
cout << a;
}
Console would print:
-nothing  

It does before it checks, whereas a regular while loop checks before it does.

Edit: I learned how to insert code! Huzzah!
Edit 2: I learned how to insert code with colors! Double huzzah!
Edit 3: Gnarl. Now I got a craving to program. While half asleep. This won't go well.
Edit 4: Edited code for difference clarification

[Rakeer]

I don't have somewhere to run code easily at hand right now, but have you tried putting in a bunch of cout statements to try to debug it? Print the input number, print the octal conversion, print the rearranged number, print the result of the subtraction, print when you're exiting the loop. It might help to find what's wrong.

You can paste it here also; maybe it'll help us see what's going wrong.

yes i have done that, i've tested it with 3418 and 123. 3418 worked perfectly all throughout (but oddly not without the cout statements >.>) and 123 returned 24 which I'm getting based on paper math is wrong, should be 28. ill run like 5 tests and post it up here in a few mins.

---------- Post added 2011-05-28 at 10:19 PM ----------

Enter a number: 3418 
 
base eight conversion 1: 6532 
 
sort 1: 
...in base 10: 1262 
number in base ten: 3418 
number-sorted: 2156 
 
sort 2: 
...in base 10: 805 
number in base ten: 2156 
number-sorted: 1351 
 
sort 3: 
...in base 10: 175 
number in base ten: 1351 
number-sorted: 1176 
 
sort 4: 
...in base 10: 147 
number in base ten: 1176 
number-sorted: 1029 
 
sort 5: 
...in base 10: 21 
number in base ten: 1029 
number-sorted: 1008 
 
number in base 8: 1760 
final number: 1008  

answer is suppose to be 1008, so that one is good for some reason : /

Enter a number: 123 
base eight conversion 1: 173 
 
sort 1: 
number in base ten: 123 
number-sorted: 28 
 
sort 2: 
number in base ten: 28 
 
number in base 8: 28 
final number: 24  

answer is spose to be 28.

Enter a number: 5049 
base eight conversion 1: 11671 
 
sort 1: 
number in base ten: 5049 
number-sorted: 322 
 
sort 2: 
number in base ten: 322 
number-sorted: 301 
 
sort 3: 
number in base ten: 301 
 
number in base eight: 301 
final number: 193  

answer is suppose to be 301.
changes inbetween the /*/

void main(){ 
    int number; 
    int sorted; 
    int counter; 
    int temp; 
 
    for(int ia = 0; ia < 5; ia++){ 
        number = 0; 
        sorted = 0; 
        counter = 0; 
        temp = 0; 
        system("cls"); 
        cout << "Enter a number: "; 
        cin >> number; 
        temp = number; 
        number = base_eight(number); 
        [B]cout << "base eight conversion " << counter + 1 << ": " << number << endl;[/B] 
 
        while(1){ 
            sorted = sort(number); 
            /*/cout << "sort " << counter + 1 << ": " << endl;/*/ 
            sorted = base_ten(sorted); 
            /*/cout << "...in base 10: " << sorted << endl;/*/     
                        number = base_ten(number); 
            /*/cout << "number in base ten: " << number << endl;/*/ 
            if(number == sorted) 
                break; 
            number = number - sorted; 
            /*/cout << "number-sorted: " << number << endl;/*/ 
            number = base_eight(number); 
            /*/cout << "...in base 10" << endl;/*/ 
            counter++; 
            if(counter == 5) 
                break; 
        } 
        /*/cout << "number in base 8: " << number << endl;/*/ 
        number = base_ten(number); 
        cout << "final number: " << number << endl; 
 
 
        cout << number << "." << endl; 
        system("PAUSE"); 
    } 
}  

now that i look at it this way i see that i am getting the answers just before the end. bah. ill be trying some more on this tomorrow after i sleep some. thanks in advance for your guys help.

[Yohassakura]

Sorry, the swap that i mentioned is actually supposed to be more like:

(Note, index has to be at the last number, for this configuration to work, so i guess that this would be equivalent to your 'counter'.)

 for (int j=0; j < index-1; j++) { //checks the value at index 0 + index 1
            //^if it's not larger, move to the next index values (and repeat).
            for (int k=0; k < index-1; k++) { //k is 0, but while it's less than 1 keep adding 1 to k
                //if k is greater than the number in the next array's index value, then move k up one slot
                if (intArray[k] > intArray[k+1]) {      
                    temp = intArrayTwo[k]; //temp = whatever value is in the array at (variable called 'k')
                    intArrayTwo[k] = intArrayTwo[k+1]; //the value of k is now +1 of k
                    intArrayTwo[k+1] = temp; //k+1 is now equal to the temporary figure
                                       
                    System.out.println("Swap " + swapValue); //print how many swaps have happened
                    swapValue = swapValue+1; //Add 1 to swapvalue for each time it loops around
                    
                    UserInput.readString(); //Slow process down by requiring the user to hit 'Enter' key.                    
                }
            }
        }

I blame the time for my mistake, will edit above post... And will hopefully have the answer soon.

Edit; Too bad my c++ compiler doesn't seem to actually work. Stupid MS -_-'

[Sunshine]

Ah, I see the problem. Notice this:

number in base ten: 28

number in base 8: 28

Plus, the fact that it only happens where you exit the loop early, not the one where you finish 5 iterations.

Not going to post the full actual answer, since it's still good practice to find that yourself.

[Rakeer]

THanks for the help guys, finally got it after sunshine pointed out the loop thing. but I have made on odd thing. I used a bunch of cout statements (as in i was outputting every variable after it was changed even in the most tedial way) and it worked. But if i remove them the program doesn't work lol >.>

[Sunshine]

Can you post the complete code now with the commented out statements? That sounds pretty weird.

[Rakeer]

#include <stdAfx.h> 
#include <iostream> 
using namespace std; 
 
int base_eight(int number); 
int sort(int number); 
int base_ten(int number); 
int calculate(int number); 
 
void main(){ 
    int number; 
    int temp; 
 
    for(int ia = 0; ia < 5; ia++){ 
        cout << "Enter a number: "; 
        cin >> number; 
        temp = number; 
 
        number = calculate(number); 
        system("cls"); 
        cout << "The 'Botchagaloop' of " << temp << " is " << number << "." << endl; 
        system("PAUSE"); 
        system("cls"); 
    } 
} 
int base_eight(int number){ 
    int place[100]; 
    int first = 0; 
    int counter = 0; 
    int octal = 0; 
    int power; 
    while(1){ 
        place[counter] = number % 8; 
        counter++; 
        first = number / 8; 
         
        if(first < 8) 
            break; 
 
        number = first; 
    } 
 
    place[counter] = first; 
 
    for(int ia = 0; ia <= counter; ia++){ 
        power = 1; 
        for(int ib = 0; ib < counter - ia; ib++){ 
            power = power * 10; 
        } 
        octal = octal + (place[counter - ia] * power); 
    } 
    return octal; 
} 
int sort(int number){ 
    //will turn 4154 into 1445 
    int counter = 0; 
    int digit[101]; 
    int place[101]; 
    int final; 
     
    //break the number 
    while(1){ 
        digit[counter] = number % 10; 
        if(number == digit[counter]) 
            break; 
        number = number - digit[counter]; 
        counter++; 
        number = number / 10; 
    } 
 
    //number the places 
    for(int ia = 0; ia <= counter; ia++){ 
        place[ia] = 0; 
        for(int ib = 0; ib <= counter; ib++){ 
            if(ib != ia){ 
                if(digit[ia] < digit[ib]){ 
                    place[ia]++; 
                } 
            } 
        } 
        for(int ic = 0; ic <= counter; ic++){ 
            if(ic != ia){ 
                if(place[ia] == place[ic]) 
                    place[ia]++; 
            } 
        } 
    } 
 
    for(int ic = 0; ic <= counter; ic++){ 
        for(int id = 0; id < place[ic]; id++){ 
            digit[ic] = digit[ic] * 10; 
        } 
        final = final + digit[ic]; 
    } 
 
    return final; 
} 
int base_ten(int number){ 
    int digit[101]; 
    int counter = 0; 
    int final = 0; 
 
    while(1){ 
        digit[counter] = number % 10; 
        if(number == digit[counter]) 
            break; 
        number = number - digit[counter]; 
        counter++; 
        number = number / 10; 
    } 
 
    for(int ia = 0; ia <= counter; ia++){ 
        for(int ib = 0; ib <= counter - ia - 1; ib++){ 
            digit[counter - ia] = digit[counter - ia] * 8; 
        } 
        final = final + digit[counter - ia]; 
    } 
     
    return final; 
} 
int calculate(int number){ 
    int sorted; 
    number = base_eight(number); 
    cout << "In base eight: " << number << endl; 
    sorted = sort(number); 
    cout << "Base eight sorted: " << sorted << endl; 
 
    number = base_ten(number); 
    cout << "Original number in base ten: " << number << endl; 
    sorted = base_ten(sorted); 
    cout << "Sorted number in base ten: " << number << endl; 
    cout << number; 
    number = number - sorted; 
    cout << "-" << sorted << " = " << number << endl; 
    system("PAUSE"); 
    system("cls"); 
 
    number = base_eight(number); 
    cout << "New number in base eight: " << number << endl; 
    sorted = sort(number); 
    cout << "New number sorted: " << sorted << endl; 
    if(sorted == number){ 
        number = base_ten(number); 
        return number; 
    } 
 
    number = base_ten(number); 
    cout << "New number in base ten: " << number << endl; 
    sorted = base_ten(sorted); 
    cout << "New sorted in base ten: " << sorted << endl; 
    cout << number; 
    number = number - sorted; 
    cout << "-" << sorted << " = " << number << endl; 
    system("PAUSE"); 
    system("cls"); 
 
    number = base_eight(number); 
    cout << "New number in base eight: " << number << endl; 
    sorted = sort(number); 
    cout << "New number sorted: " << sorted << endl; 
    if(sorted == number){ 
        number = base_ten(number); 
        return number; 
    } 
 
    number = base_ten(number); 
    cout << "New number in base ten: " << number << endl; 
    sorted = base_ten(sorted); 
    cout << "New sorted in base ten: " << sorted << endl; 
    cout << number; 
    number = number - sorted; 
    cout << "-" << sorted << " = " << number << endl; 
    system("PAUSE"); 
    system("cls"); 
 
    number = base_eight(number); 
    cout << "New number in base eight: " << number << endl; 
    sorted = sort(number); 
    cout << "New number sorted: " << sorted << endl; 
    if(sorted == number){ 
        number = base_ten(number); 
        return number; 
    } 
 
    number = base_ten(number); 
    cout << "New number in base ten: " << number << endl; 
    sorted = base_ten(sorted); 
    cout << "New sorted in base ten: " << sorted << endl; 
    cout << number; 
    number = number - sorted; 
    cout << "-" << sorted << " = " << number << endl; 
    system("PAUSE"); 
    system("cls"); 
 
    number = base_eight(number); 
    cout << "New number in base eight: " << number << endl; 
    sorted = sort(number); 
    cout << "New number sorted: " << sorted << endl; 
    if(sorted == number){ 
        number = base_ten(number); 
        return number; 
    } 
 
    number = base_ten(number); 
    cout << "New number in base ten: " << number << endl; 
    sorted = base_ten(sorted); 
    cout << "New sorted in base ten: " << sorted << endl; 
    cout << number; 
    number = number - sorted; 
    cout << "-" << sorted << " = " << number << endl; 
    system("PAUSE"); 
 
    return number; 
}  

the code is definatly not optimized or elegant, couldn't a loop to work the way i wanted it to so i just did the long way in a new function to retrun values. and when i said cout, i include the system commands.

[fsdfosdgj]

#include <stdlib.h>
#include <stdio.h>

#define SIZE unsigned int
#define TIMES_SUB 5
#define OCTETC ((((sizeof(SIZE) << 3) - 1) / 3) + 1)
#define SWAP_INT_XOR(x, y) {x^=y; y^=x; x^=y;}

SIZE octal_sort_asc(SIZE val){
	short i, j, digits[OCTETC];
	
	for(i = 0; i < OCTETC; i++)
		digits[i] = (val >> (3*i)) & 7;
	
	for(i = 0; i < OCTETC; i++)
		for(j = 0; j < OCTETC; j++)
			if(digits[i] > digits[j]) 
				SWAP_INT_XOR(digits[i], digits[j]);
	
	val = 0;
	for(i = 0; i < OCTETC; i++)
		val += digits[i] << (3*i);
	
	return val;
}

int main(int argc, char *argv[]){
	SIZE val, newval;
	short i;

	printf("input value: %0*o\n", OCTETC, val = atoi(argv[1]));
	printf("sorted input value: %0*o\n", OCTETC, newval = octal_sort_asc(val));
	
	for(i = 0; i < TIMES_SUB; i++){
		printf("%0*o - %0*o = %0*o\n", OCTETC, val+newval, OCTETC, newval, OCTETC, val-=newval);
		if(val == octal_sort_asc(val))
			break;
	}
	
	return 0;
}

i fail to see the point why you make a difference between base8 and base10 arithmetic. because there is none.

[Rakeer]

i fail to see the point why you make a difference between base8 and base10 arithmetic. because there is none.

i did it because subtraction, and all forms of math, differ if the bases differ. as i do not know how to properly express subtraction of octals, i convertered back and forth to get the same number. just a longer road that i understand.