The chances decrease with each update, and they were vanishingly small to begin with.
Not only were Void Elves introduced just to give the Alliance the model without giving them a clone of a core Horde race, but now we see that any thoughts that alliance high elves are 'purer' than Blood Elves have been dispelled. An impure race would not go around sporting golden eyes reflecting the holy energy pumping through their veins.
The green eyes are a legacy of an old mistake in other words, and not representative of the race as it is now or will be in the future.
I'd love to see these golden options made available to players, even if I intend to keep the green tint myself. I'm Irish, green is a favorite colour.
Even if they are NPC only, it still has the same effect on lore by proving the green eyes, and by proxy the taint, are no longer a definitive feature of being a Blood Elf.