Been a while since I posted.
Did some theorycrafting to try and fix up the T21 4pc. Most of it was done on raidbots and I didn't go into details with legendary items.
Legendary Items disabled
All sims use same stats (T20M loadout) (gear doesn't matter)
TSM trinket used because it's popular.
Crucible effects disabled
Code:
T21 4pc bonus:
override.spell_data=effect.472819.base_value=25
override.spell_data=effect.472820.base_value=25
T21 2pc bonus (hack fix):
override.spell_data=effect.68268.sp_coefficient=5.72
override.spell_data=effect.280158.sp_coefficient=0.50336
To make it as clear as possible, these sims use the "new" 2pc bonus (Starfall + Starsurge, 10% damage buff). At the time of sims, this 2pc effect had not been pushed to simcraft. So I used overrides, as seen above. The hack-fix for the T21 2pc bonus is included on the T21 tests where labelled. Both "CURRENT" and "OVERRIDE" sims use the hack-fix. In addition, This override was excluded from the baseline value, so the baseline is accurate. Basically, I was forced to turn the set bonus active when I did this hack-fix, so I had to do a bit more work to get the proper testing. But this is accurate. Set bonuses are explicitly enabled and disabled according to simulation data.
Basically, overriding spelldata isn't "sim-specific" during meta reports. It's fine, just a bit more work.
There's a bit of data, so here are the results. The "override" is 25%, in case you couldn't figure that from the override code (up from 10%).
Code:
Single-Target (T21 results)
T21_2pc_4pc = 991,703 (6.0%) (OVERRIDE -- 4pc)
T21_2pc_4pc = 975,014 (4.2%) (CURRENT)
T21_2pc = 964,358 (3.0%)
T21_4pc = 963,092 (2.9%) (OVERRIDE)
T21_4pc = 946,204 (1.1%) (CURRENT)
Baseline = 935,605 ----
.
Code:
Single-Target (Patchwerk)
T20_2pc_4pc = 1,030,344 (10.1%)
T19_2pc_4pc = 1,011,993 (8.2%)
T20_4pc = 994,495 (6.3%)
T19_4pc = 994,263 (6.3%)
T21_2pc_4pc = 991,703 (6.0%) (OVERRIDE --- 4pc)
T21_2pc_4pc = 975,014 (4.2%) (CURRENT)
T19_2pc = 969,363 (3.6%)
T21_2pc = 964,358 (3.0%)
T21_4pc = 963,092 (2.9%) (OVERRIDE)
T20_2pc = 962,795 (2.9%)
T21_4pc = 946,204 (1.1%) (CURRENT)
Baseline = 935,605 ----
.
Code:
Beastlord (semi-AOE; more realistic and it isn't a 4-6min AOE fest...which doesn't exist.)
T21_2pc_4pc = 1,194,364 (9.5%) (OVERRIDE --- 4pc)
T21_4pc = 1,171,988 (7.5%) (OVERRIDE)
T20_2pc_4pc = 1,166,155 (7.0%)
T20_4pc = 1,157,017 (6.1%)
T21_2pc_4pc = 1,144,611 (5.0%) (CURRENT)
T21_4pc = 1,122,632 (3.0%) (CURRENT)
T21_2pc = 1,112,799 (2.1%)
T19_2pc_4pc = 1,112,260 (2.1%)
T19_4pc = 1,101,758 (1.0%)
T19_2pc = 1,100,769 (1.0%)
T20_2pc = 1,093,633 (0.3%)
Baseline = 1,090,188 ----