Potions/Flasks will be expensive for a while I'd wager since nobody is doing Nazjatar anymore and therefore there's far less Zin'anthid on the market. It's around 45g each on my server whereas last patch it was down under 20g a lot of the time. Add to that the fact that people are using more flasks/potions than before since they're still progressing in the raid and high m+ keys and prices are really inflated at the moment.
Personally I don't even use pots/flasks, not spending 200g every other pull in a m+, definitely not that tryhard. And my guild isn't wiping in a heroic raid because I didn't use a potion, so I really don't even see the point if you aren't pushing mythic raids.
That being said, as someone with Alchemy I've been loving it. Buy the mats on the AH, craft a couple hundred potions, resell for 20k profit, repeat daily.