1. #1

    NPC Hider Shadowlands

    For a while I have been using an addon called NPC Hider. As what usually happens with a patch, it gets broken because new textures and stuff get added that it has to be updated to filter out. Shadowlands has been no different in the need for an update. However, the author has taken some curious, and rather suspicious actions lately.

    First he has removed the ability to comment on the curseforge page when that has always been allowed on his page. It's not a very big addon so the volume of comments have never been very large, but more importantly it's been a place where users have sometimes given band-aid fixes until the author releases a new version. Second, he has removed all previous versions from the curseforge site, and the only version available for download is the most recent one. Thankfully I have backups so I have comparison for the next part. He has essentially (and seemingly intentionally) deleted large portions of what appear to be essential code. Examples will be shown below. He has also completely made the TGA files with the filtered textures blank. Opening them up in TGA viewer shows them to be completely blank, while the old versions have many icons in them.

    I have tried to use the old code file, and while it does make the addon work, it has the textures all over the place, and stable masters and legion assault ships are all over my minimap. I've never had any problems with curseforge corrupting files, though I know twitch sometimes selects classic addons for retail players but that does not appear to be the problem here. I'm posting here since comments are turned off on the curseforge and I don't have the artistic skills necessary to figure out how to make the old TGA files show the textures I want. I guess my question is does anyone know what's going on with this addon or have a working copy?

    https://www.curseforge.com/wow/addons/npchider

    Old Version that worked sample

    Code:
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil)
    local lastSetting = ""
    local OneTexture = "Interface\\AddOns\\NpcHider\\One"
    local TwoTexture = "Interface\\AddOns\\NpcHider\\Two"
    local ThreeTexture = "Interface\\AddOns\\NpcHider\\Three"
    local FourTexture = "Interface\\AddOns\\NpcHider\\Four"
    local FiveTexture = "Interface\\AddOns\\NpcHider\\Five"
    local SixTexture = "Interface\\AddOns\\NpcHider\\Six"
    local SevenTexture = "Interface\\AddOns\\NpcHider\\Seven"
    local AllTexture = "Interface\\AddOns\\NpcHider\\All"
    New version that doesn't work

    Code:
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil)
    local lastSetting = ""
    
    local FourTexture = "Interface\\AddOns\\NpcHider\\Four"
    local FiveTexture = "Interface\\AddOns\\NpcHider\\Five"
    local AllTexture = "Interface\\AddOns\\NpcHider\\All"

  2. #2
    Quote Originally Posted by Xloudman View Post
    Code:
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil)
    that has to be changed to
    Code:
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil, BackdropTemplateMixin and "BackdropTemplate")

    source: https://www.wowinterface.com/forums/...ad.php?t=58109

  3. #3
    Quote Originally Posted by tmamass View Post
    that has to be changed to
    Code:
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil, BackdropTemplateMixin and "BackdropTemplate")
    source: https://www.wowinterface.com/forums/...ad.php?t=58109
    It's still doing it, here's the full code on the source thing and a picture of what it's doing.
    I think it might be something in the TGA files if it's trying to reference a different part of the image for the texture or something.



    Code:
    --[[		NpcHider v1.3.6
    ]]--		by Ravens (source by kriptonitte)
    local NpcHide = CreateFrame("Frame", "NpcHideFrame", nil, BackdropTemplateMixin and "BackdropTemplate")
    local lastSetting = ""
    local OneTexture = "Interface\\AddOns\\NpcHider\\One"
    local TwoTexture = "Interface\\AddOns\\NpcHider\\Two"
    local ThreeTexture = "Interface\\AddOns\\NpcHider\\Three"
    local FourTexture = "Interface\\AddOns\\NpcHider\\Four"
    local FiveTexture = "Interface\\AddOns\\NpcHider\\Five"
    local SixTexture = "Interface\\AddOns\\NpcHider\\Six"
    local SevenTexture = "Interface\\AddOns\\NpcHider\\Seven"
    local AllTexture = "Interface\\AddOns\\NpcHider\\All"
    
    SLASH_NPCHIDE1, SLASH_NPCHIDE2 = '/hide', '/nh';
    local function slashhandler(msg, editbox)
    
    	if (msg == '1') then
    		Minimap:SetBlipTexture(TwoTexture)
    		if editbox then print('Showing Players Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == '2') then
    		Minimap:SetBlipTexture(ThreeTexture)
    		if editbox then print('Showing NPCs & Mobs Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == '3') then
    		Minimap:SetBlipTexture(SixTexture)
    		if editbox then print('Showing Enemy Players Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == '4') then
    		Minimap:SetBlipTexture(SevenTexture)
    		if editbox then print('Showing Friendly Players Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == '5') then
    		Minimap:SetBlipTexture(FourTexture)
    		if editbox then print('Showing NPCs, Mobs, & Enemy Players Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == '6') then
    		Minimap:SetBlipTexture(FiveTexture)
    		if editbox then print('Showing NPCs, Mobs, & Friendly Players Only') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == 'everything') then
    		Minimap:SetBlipTexture(AllTexture)
    		if editbox then print('Gul*dan Mode Activated: Showing Strictly Hostile Enemy Player Icons Only! Hiding EVERYTHING! All minimap icons such as quest objectives, pvp objectives, townsfolk, points of interest, party members, nodes etc, are now all hidden. Happy Hunting!') end
    		_HideNPC.setting = msg
    		_HideNPC.toggle = msg
    	elseif (msg == 'reset') then
    		Minimap:SetBlipTexture(OneTexture)
    		if editbox then print("NpcHider Reset - Showing All") end
    		_HideNPC.setting = msg
    	elseif (msg == 'toggle') then
    		toggle()
    	else
    		print('Type /nh or /hide plus a following command:')
    		print('1 -- Show Players Only')
    		print('2 -- Show NPCs & Mobs Only')
    		print('3 -- Show Enemy Players Only')
    		print('4 -- Show Friendly Players Only')
    		print('5 -- Show NPCs, Mobs, & Enemy Players Only')
    		print('6 -- Show NPCs, Mobs, & Friendly Players Only')
    		print('reset -- Show Everything (resets last used option)')
    		print('toggle -- Enable/Disable NpcHider (retains last used option)')
    		print('--------------------------------------------------------------------------')
    		print('note: mobs = hunter tracking; beasts/demons/dragonkin/elementals/ghosts/giants/undead.')
    	end
    end
    
    function toggle()
    
    	if not _HideNPC.setting then
    		slashhandler('1',nil)
    	elseif _HideNPC.setting == '1' or _HideNPC.setting == '2' or _HideNPC.setting == '3' or _HideNPC.setting == '4' or _HideNPC.setting == '5' or _HideNPC.setting == '6' then
    		slashhandler('reset',nil)
    	elseif _HideNPC.setting == 'reset' then
    		slashhandler(_HideNPC.toggle, nil)
    	end
    end
    SlashCmdList["NPCHIDE"] = slashhandler;
    
    local function onEvent(self, event, addonName, ...)
    	
    	if (event == "ADDON_LOADED" and addonName == "NpcHider") then
    	
    		if _HideNPC and not _HideNPC["setting"] then
    			
    			_HideNPC = {
    				["setting"] = "1",
    				["toggle"] = "1"
    			}
    		end
    	
    		if _HideNPC == nil then
    			_HideNPC = {
    				["setting"] = "1",
    				["toggle"] = "1"
    			}
    		end
    		
    		slashhandler(_HideNPC.setting, nil)
    		
    	end
    	
    end
    
    NpcHide:RegisterEvent("ADDON_LOADED")
    NpcHide:SetScript("OnEvent", onEvent)
    Last edited by Xloudman; 2020-10-15 at 04:50 AM. Reason: formatting

  4. #4
    Hi!

    I've got the same problem. Sadly I already updated to the newest version and can't access the old version anymore. I might be able to make a bandaid fix. Can you send me the the most recent somewhat working version?

  5. #5
    Quote Originally Posted by Vhaen View Post
    Hi!

    I've got the same problem. Sadly I already updated to the newest version and can't access the old version anymore. I might be able to make a bandaid fix. Can you send me the the most recent somewhat working version?
    Yeah I can, is there a place you'd prefer it uploaded?

  6. #6
    Welp, the author has removed it from curseforge as far as I can tell.

  7. #7
    Quote Originally Posted by Xloudman View Post
    Welp, the author has removed it from curseforge as far as I can tell.

    Looks like we have some context, and it was a clone of https://www.curseforge.com/wow/addons/hidenpctracking

    https://www.reddit.com/r/wow/comment...eloper/g9ahjt9
    Hey I developed a pvp addon for wow since WoD... and I faced similar issues with people being insulting or demanding quick fixes in DMs, etc whenever blizzard rolls out a new patch that broke it.

    Enough is Enough for Shadowlands I decided to burn everything, had one moron get entitled when Pre-Patch launched.. I deleted all past downloads, intentionally uploaded a broken scripted version to wipe out the version on people's computers, so that way not even those who like to work on their own fixes can roll out a fix as now they have no previous working copy to work from. Then after a few days of thousands of downloads, I deleted the curseforge entry. Now I just get messages asking why I deleted the addon.

    So now only my friends and myself have the only legit working copies of my pvp addon :P

  8. #8
    Quote Originally Posted by Ketho View Post
    Looks like the comment/post has since been deleted so thank you for copying it. I knew it was a ripoff of hidenpctracking since npchider said it in the description and since hidenpctracking no longer gets updated. Tbh I hadn't thought to check the old one's curseforge page and it looks like they have a fan updated one there so I'm going to try that and see how it works.

  9. #9
    Quote Originally Posted by Xloudman View Post
    Looks like the comment/post has since been deleted so thank you for copying it. I knew it was a ripoff of hidenpctracking since npchider said it in the description and since hidenpctracking no longer gets updated. Tbh I hadn't thought to check the old one's curseforge page and it looks like they have a fan updated one there so I'm going to try that and see how it works.

    please share if you found a solution

  10. #10
    Quote Originally Posted by Comonier View Post
    please share if you found a solution
    https://www.curseforge.com/wow/addon...ing?comment=80 The version linked here seems to work

  11. #11
    i tested its fine ty

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •