You say that up until it is your class and you never get invited to anything lol.
I think a lot of Hitei's rant is accurate, but it is funny talking about bm hunters in particular when they (and hunters in general) haven't been meta in multiple expansions (but are usually completely fine in most content). Rogues have consistently been good in organized and casual pvp (not a shock), they are also doing well in high m+ atm (
https://raider.io/mythic-plus-rankin...MythicLevel=99). All 3 specs are also showing up in mythic raid, with asn being in the top 1/3 for parse numbers.
Anyway BFA was the death knell for unique rogue stuff because shroud was completely mandatory for a huge swath of that xpack, on top of combat being broken. That ability will probably never be that required again.