Please help me with lua code

Deleted · 2011-10-12, 07:38 AM

Code:

-- Load Variables
if type(INSraid) ~= "boolean" then
	INSraid = false;
else
end
if type(INSparty) ~= "boolean" then
	INSparty = false;
else
end
if type(INSyell) ~= "boolean" then
	INSyell = true;
else
end

if type(INSsay) ~= "boolean" then
	INSsay = true;
else
end

if type(INSself) ~= "boolean" then
 INSself = true;
else
end

if type(INSspell) ~= "boolean" then
 INSspell = true;
else
end

if type(INStarget) ~= "boolean" then
 INStarget = true;
else
end

-- Define Event Action
local function OnEvent(self, event, ...)
	if ( event == "PLAYER_LOGIN" ) then
		self:UnregisterEvent("PLAYER_LOGIN");
		self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
	elseif ( event == "COMBAT_LOG_EVENT_UNFILTERED" ) then
		local numParty	= GetNumPartyMembers();
		
		local timestamp, eventType, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags, spellID, spellName, _, extraskillID, extraskillname = ...; 
		if (eventType == "SPELL_INTERRUPT") and sourceName == UnitName("player") then
			intmsg = ("Interrupted");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		end
	end;
end

-- Register Event
local SuccessfulInterruptAnnouncer = CreateFrame("Frame")
SuccessfulInterruptAnnouncer:RegisterEvent("PLAYER_LOGIN")
SuccessfulInterruptAnnouncer:SetScript("OnEvent", OnEvent)

I have this part of the code but doesn't work with some interrupts lately. What should I change to make it work? Thanks

Deleted · 2011-10-12, 07:45 AM

What interrupts doesn't it work with?

Also, holy global leak batman.
What did the poor namespace do to you to deserve being mutilated like that?

Deleted · 2011-10-12, 09:09 AM

Spell Lock, gag order, Avenger's Shield
What about namespace?

**Ketho** · 2011-10-12, 07:14 PM

Originally Posted by Treeston

Also, holy global leak batman.
What did the poor namespace do to you to deserve being mutilated like that?

At least he prefixed "INS" in the variables ^^

Originally Posted by arapis

Spell Lock, gag order, Avenger's Shield

If it doesn't show up these certain spells then I'm thinking the SPELL_INTERRUPT event didn't fire; or it's only silencing instead of interrupting. otherwise I don't know :s

Deleted · 2011-10-13, 04:59 PM

Any help please? What should i change?

**Tahirii** · 2011-10-13, 10:11 PM

When you say it doesn't work for Gag Order, do you mean it doesn't work in conjunction with Heroic Throw or does it not work with Pummel either?

If the former my thought is similar to Ketho, silences aren't triggering the SPELL_INTERRUPT event. I believe silence effects put a debuff on the target, perhaps you can check for that.
Psuedocode only as I can't post real code yet but,

if eventType == "SPELL_AURA_APPLIED" and destName == UnitName("target") and spellID == (id's of silence debuffs) then

Might work for you. Now if these spells don't actually put a debuff on the target then this is useless and I'll try and think of something else

Deleted · 2011-10-15, 05:03 PM

i got this error now after adding it actually

Code:

Message: ...lInterruptAnnouncer\SuccessfulInterruptAnnouncer.lua:83: attempt to concatenate a nil value
Time: 10/15/11 16:34:29
Count: 10
Stack: ...lInterruptAnnouncer\SuccessfulInterruptAnnouncer.lua:83: in function <...lInterruptAnnouncer\SuccessfulInterruptAnnouncer.lua:36>

Locals: self = <unnamed> {
0 = <userdata>
}
event = "COMBAT_LOG_EVENT_UNFILTERED"
numParty = 4
timestamp = 1318689275.11
eventType = "SPELL_AURA_APPLIED"
hideCaster = false
sourceGUID = "0x05000000040A7517"
sourceName = "Daroyce-Frostmane"
sourceFlags = 1298
sourceRaidFlags = 0
destGUID = "0xF130191A00007668"
destName = "Anguished Dead"
destFlags = 68168
destRaidFlags = 0
spellID = 31935
spellName = "Avenger's Shield"
_ = 2
extraskillID = "DEBUFF"
extraskillname = nil
(*temporary) = "Interrupted"
(*temporary) = " "
(*temporary) = nil
(*temporary) = "DEBUFF"
(*temporary) = "attempt to concatenate a nil value"

-- Load Variables
if type(INSraid) ~= "boolean" then
INSraid = false;
else
end
if type(INSparty) ~= "boolean" then
INSparty = false;
else
end
if type(INSyell) ~= "boolean" then
INSyell = true;
else
end

if type(INSsay) ~= "boolean" then
INSsay = true;
else
end

if type(INSself) ~= "boolean" then
INSself = true;
else
end

if type(INSspell) ~= "boolean" then
INSspell = true;
else
end

if type(INStarget) ~= "boolean" then
INStarget = true;
else
end

Code:

-- Define Event Action
local function OnEvent(self, event, ...)
	if ( event == "PLAYER_LOGIN" ) then
		self:UnregisterEvent("PLAYER_LOGIN");
		self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
	elseif ( event == "COMBAT_LOG_EVENT_UNFILTERED" ) then
		local numParty	= GetNumPartyMembers();
		
		local timestamp, eventType, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags, spellID, spellName, _, extraskillID, extraskillname = ...; 
		if (eventType == "SPELL_INTERRUPT") and sourceName == UnitName("player") then
			intmsg = ("Interrupted");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		
		elseif (eventType == "SPELL_AURA_APPLIED") and destName == UnitName("target") and spellID == ("31935" or "24259" or "12311" or "12958") then
			intmsg = ("Interrupted");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		end
	end
end

Deleted · 2011-10-19, 10:24 AM

There is no extraskillID when using SPELL_AURA_APPLIED.

Also, (id or id or id or id) will only match the first ID, not all of them. Use (spellID == id) or (spellID == id) or (spellID == id).

Deleted · 2011-10-20, 09:30 PM

I made it work and thanks for that. When i tested spell lock though (didn't test the others yet) it announces 2 times. I think 1 for interrupt and 1 when the aura fades out :S

Deleted · 2011-10-21, 11:50 PM

bump bump

**Woogs** · 2011-10-22, 09:19 PM

There's a difference between interrupts and silences. Silences are debuffs, that is why you listen for SPELL_AURA_APPLIED events. When you see double messages, it is because you are using a cooldown that is both an interrupt and silence. I added SPELL_AURA_REMOVED and changed the output text a bit. Didn't test it. Good luck with your coding.

Code:

-- Define Event Action
local function OnEvent(self, event, ...)
	if ( event == "PLAYER_LOGIN" ) then
		self:UnregisterEvent("PLAYER_LOGIN");
		self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
	elseif ( event == "COMBAT_LOG_EVENT_UNFILTERED" ) then
		local numParty	= GetNumPartyMembers();
		
		local timestamp, eventType, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags, spellID, spellName, _, extraskillID, extraskillname = ...; 
		if (eventType == "SPELL_INTERRUPT") and sourceName == UnitName("player") then
			intmsg = ("Interrupted");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		
		elseif (eventType == "SPELL_AURA_APPLIED") and destName == UnitName("target") and spellID == ("31935" or "24259" or "12311" or "12958") then
			intmsg = ("Silence Applied");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		elseif (eventType == "SPELL_AURA_REMOVED") and destName == UnitName("target") and spellID == ("31935" or "24259" or "12311" or "12958") then
			intmsg = ("Silence Removed");
			if(INStarget == true) then
				intmsg = (intmsg.." "..destName)
			end

			if(INSspell == true) then
				if(INStarget == true) then
					intmsg = (intmsg.."'s "..GetSpellLink(extraskillID))
				else
					intmsg = (intmsg.." "..GetSpellLink(extraskillID))
				end
			end

			if UnitInRaid("player") and (INSraid == true) then
				SendChatMessage(intmsg, "RAID")
			elseif UnitInParty("player") and (INSparty == true) and (numParty > 0) then
				SendChatMessage(intmsg, "PARTY")
			end
			if (INSyell == true) then
				SendChatMessage(intmsg, "YELL")
			end
			if (INSsay == true) then
				SendChatMessage(intmsg, "SAY")
			end
			if (INSself == true) then
				print(intmsg)
			end
		end
	end
end

Deleted · 2011-10-22, 11:56 PM

Actually this didn't help...still announces twice, both with message "Silence applied" so it doesn't seem to distinguish the two events :/

Deleted · 2011-10-24, 06:39 AM

any ideas?

**Tahirii** · 2011-10-24, 08:03 PM

Not sure what to make of that. If it is in fact announcing "Silence applied" when you use the silence, and then saying "Silence applied" again when the silence fades, that means for some reason the SPELL_AURA_APPLIED event is triggering for both. Does what Woogs posted ever announce "Silence Removed"?

Deleted · 2011-10-24, 08:08 PM

Yes but it announces silence applied and silence removed at the start and at the end. So 4 announces in total. 2+2

Recent Blue Posts

Mythic+ Dungeon Adjustments - 27 April

Mythic+ Dungeon Adjustments - April 26

The Cataclysm Classic Pre-Expansion Patch Arrives 1 May

Get Up to 33% off Select Game Services

Get Up to 33% off Select Game Services

This Week in WoW: 19 April, 2024

This Week in WoW: April 26, 2024

Recent Forum Posts

Mythic+ Dungeon Adjustments - April 26, 2024

Dragonflight and Season of Discovery Hotfixes - April 25, 2024

S4 Elite PVP Set - Not Updated to Reflect Winning Tier? PVP Community Forgotten????

What game first sparked your interest in gaming? Was it World of Warcraft?

Best Villain in the History of WoW

Can someone please help me fix a Dialogue Bug?

The War Within Alpha Development Notes - April 25, 2024

Thread: Please help me with lua code

Thread Tools

Please help me with lua code

Posting Permissions

Social Media

Services

Resources

Our Communities

MOBAFire Network