BfA is a tough call for me...
Overall I rank it about the same as Legion, I frankly think it's just Legion 2.0, more of the same but with a different look. But I burnt out on BfA, mainly because it's been like playing the same spec/class/dungeons/raids for 4 years now. I think overall the raiding was better, maybe the dungeons were about equal to maybe a bit worse in BFA, but M+ was fresh.
Overall though I rank Legion and BFA slightly ahead of Cata, and Cata is behind Wrath, Vanilla, and TBC... so BFA has been very middle of the pack.