Night elves' eyes glow silver because Elune's status as a naaru isn't official. Much of her power is associated with moonlight--those elves whose eyes glow golden are typically made druids, as it was historically a sign of strong druidic potential.
And the blood/high elves won't be showing any noteworthy changes for at least the next couple generations, if the high elves even still have a sustainable gene pool. We're on the third generation of post-First War orcs and they're still green. When they do start showing changes, yeah, their eyes will probably glow golden from the renewed, Light-empowered Sunwell.