Page 2 of 2 FirstFirst
1
2
  1. #21
    Deleted
    The idea is to not have it in the OnUpdate.

    PS: You already only scan whether addons enabled are actually loaded.

  2. #22
    I have not used your add on but might give it a go, it looks quite nice.

    One question will it show duration of current CC on the target cause whatever tidyplates mod im using now does :>

    Also the main reason I found threatplates to be superior to most other nameplates mods is the way it treats totems and places them in a nice little group with their respective icons above the nameplate

  3. #23
    Quote Originally Posted by Treeston View Post
    The idea is to not have it in the OnUpdate.

    PS: You already only scan whether addons enabled are actually loaded.
    Exactly, I only wanted to scan from the table that is created when the UI initially loads. I populate the table of addons that are enabled and in the tooltip update code of the OnEnter function, the tooltip updates accordingly. With this:

    Code:
    if not tContains(addons, arg1) then tinsert(addons, arg1) end
    I am not seeing how to remove the IsAddOnLoaded() code? Since I am only scanning whether addons enabled are actually loaded, will the ADDON_LOADED event even matter? I am lost, I'm sorry, please point me in the right direction.

    ---------- Post added 2011-02-22 at 08:41 PM ----------

    Quote Originally Posted by Strlder View Post
    I have not used your add on but might give it a go, it looks quite nice.

    One question will it show duration of current CC on the target cause whatever tidyplates mod im using now does :>

    Also the main reason I found threatplates to be superior to most other nameplates mods is the way it treats totems and places them in a nice little group with their respective icons above the nameplate
    Unfortunately, it does not do what tidyplates does in regards to CC and totems. Not yet at least.

  4. #24
    Deleted
    Make your table key => value, make the addon name the key, and the value "false". Then, check for ADDON_LOADED and set the value to true accordingly.

  5. #25
    Oh, I see, so the initial population of the table should create a table where the key = name of addon and the value = false initially. Now when you say to check for the event ADDON_LOADED, isn't that the same as just calling IsAddOnLoaded('name') function? If so, wouldn't I need to check for that in the Updating tooltip OnEnter function anyways? When would I check/change the value to true/false?

    Also, wouldn't I want to keep the value of the 4th return of GetAddOnInfo?

    Actually I'm an idiot...I see what you are saying. I should handle the event ADDON_LOADED in a separate script instead of onupdate
    Last edited by Sheykh; 2011-02-23 at 02:13 AM.

  6. #26
    Ok what I meant is that from using shPerformance I have noticed a gradual and persistent increase in the total memory used by addons, but as of yet I have not been able to identify the addon in question.
    I was wondering if would be realistic to have an option or if you know of something else which will show perhaps instead of just the current memory usage of each addon the increase in memory usage of each as an increase from some initial value.
    I understand memory usage is not impacting on performance much, but since the increase is pretty consistent then it does point towards one addon being the culprit and I would at least like an idea which it is, and with a more realistic approach than mass disabling.
    Last edited by ComputerNerd; 2011-02-23 at 06:10 AM.

  7. #27
    shNameplates is my favourite Nameplates addon. Suggestions on it, though: Add a minimal UI for the config. Add an option to reduce the width of the nameplate (or is it enough that I just reduce the width of the healthbar in config.lua for this effect?) Make the difference between aggro and non-aggro in non-tanking mode more visible (my suggestion: A Border in a "very different color" around the nameplate, like rid or anything), in the latest version the difference seemed to me not big enough and I ended up using tanking mode even for DD's to make the difference more visible.

  8. #28
    Deleted
    Quote Originally Posted by Sheykh View Post
    Oh, I see, so the initial population of the table should create a table where the key = name of addon and the value = false initially. Now when you say to check for the event ADDON_LOADED, isn't that the same as just calling IsAddOnLoaded('name') function? If so, wouldn't I need to check for that in the Updating tooltip OnEnter function anyways? When would I check/change the value to true/false?

    Also, wouldn't I want to keep the value of the 4th return of GetAddOnInfo?

    Actually I'm an idiot...I see what you are saying. I should handle the event ADDON_LOADED in a separate script instead of onupdate
    Exactly. That way, you update the value once and don't have to call the function every time.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •