The Gamecube controller, by far. It fits my hands perfectly and the buttons are well laid out (except for that Z button). I wish the Wii U Pro Controller was closer to it than an Xbox controller.
PS2 and 360 controllers are tied for second place. I find the 360 controller more comfortable, but I like the Playstation's pressure sensitive buttons and it has a better D-pad.