Frankly, I think the Orcish tribes were done justice in WoD. Although WoD was a bit of a lark storywise, its worldbuilding was generally quite good and gave the different clans a good bit of flavor and their own traditions and culture. I could easily differentiate the architectural styles, aesthetics, and personalities of every given Orc clan. In a similar connection, BfA did Kul Tiras justice even in spite of its awkward overall story—not every kingdom can be given that much content, obviously, but it does set a comparative bar for identity and aesthetic uniqueness.
- - - Updated - - -
Golden is a serviceable writer by modern Blizzard standards, but she's definitely not good at writing politics or war. She's far too preoccupied with shipping and aesthetics and the like. Not to say that either are bad, of course – Trollope, for instance, had plenty of time dedicated to aesthetics and seemed himself somewhat concerned with shipping - but there's a certain excess about it.
- - - Updated - - -
I really don't understand the black-and-white rhetoric employed by many posters on this thread. The point is that they're still villains, albeit sympathetic ones. They're a political organization that has long overstepped their right to revolution and been reduced to banditry, murder, and piracy, much like a good number of historical revolutions in our world. The Defias are somewhat comparable to the Red Army or the like, a revolutionary force entirely justified in its sentiment yet unjustified in its methodology.
This can exist in the instance of either heroes or villains—there's some subjective judgements to be made and normative analysis to be undertaken in regards to the Defias. However, this particular narrative broadly suggests that Stormwind is the lesser of all evils in this particular case, especially accounting for their relative diminished responsibility due to Onyxia's influence. Personally, I think they have long since overstepped the boundaries of the ends justifying the means due to their relative decay in motivation over time—this is a good thing on a Doylist level, because it makes for a very nuanced and interesting group of villains that you can't just slaughter wholesale without having to wonder if you are no less of villains for doing so. It's the same for me as the Red Army or whathaveyou, villains who are potentially justifiable in their ends and unjustified in their means. They're still bad guys, but nobody is inclined to defend the Tsar, either.
I will say that I think it's very silly and a little bit objectionable to reduce the definition of terrorism to any kind of violent resistance to the government. There is a particular definition of what constitutes real terrorism as opposed to revolutionary activity, and I think the Defias long since crossed that line—their banditry seems to extend beyond what is necessary to fund their organization, and their terrorism seems to be more for the purpose of acquiring personal justice rather than to better the lives of other citizens of Stormwind. They also never really seem to progress towards the goal of being compensated for rebuilding the city or the like at this point, and the fact that they're maintaining a Juggernaut for the purposes of inflicting destruction rather than to exert for power projection for the sake of eventual negotiation suggests that their goal has become more vindictive than constructive. Even assuming that Vanessa's Defias is different from its predecessors and sincerely wants to better Stormwind, not much good comes of firing indiscriminately at random people in the way of your perceived revolutionary ends—sort of proceeding from that, I'd imagine that her leadership may not be too pleasant if she actually takes power. Usually, purging the bad tyrants sounds like a nice idea until you realize that such an undertaking frequently devolves into rampant scapegoating, political infighting and eventual violence between subfactions, outright classicide regardless of fault, and eventually nigh-indiscriminate murder in the interest of consolidating power, eradicating perceived political enemies in certain classes, including those which all societies need to function (i.e. intellectuals, clergy, etc.)
One thing I will add as an addendum is that modern WoW villains probably couldn't spawn this degree of discussion. This group of revolutionary bandits and pirates living in a cave can spark more intelligent and nuanced discussion than a character whose supposed profundity and depth was supposed to carry the last expansion.