I always find theorycrafting funny, but putting so much effort into something and not even checking the base values you are calculating from is pretty ridiculous.
Putting that aside, I personally don't find double RoP good idea. I haven't tried it, I haven't even checked most of the reddit threads, it just feels wrong for me because you sacrifice one more inventory slot for item you will probably get rid of pretty early. It may work out well on some low armored ranged heroes or in specific situation or lineups, but overall I don't think it's even worth so much attention.
OT: Stout shield on melee heroes is godlike though. The ability to tank creeps easily and such a big reduction to early lane harass has really put it on my number 1 choice on almost every melee hero I play and I really suffer when I see melee carry on my team getting harassed hard on lane and not spending the 250 gold for it. I know this is not the primary scope of the discussion, I just wanted to mention how awesome it is.